Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump raisins to support React 18 #22

Merged
merged 28 commits into from
Oct 2, 2024
Merged

Bump raisins to support React 18 #22

merged 28 commits into from
Oct 2, 2024

Conversation

00salmon
Copy link
Contributor

@00salmon 00salmon commented Oct 2, 2024 •
edited
Loading

Description of the change

Adds support for React 18, also bumps jotai version from 1 to 2

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Development tools (readme, specs, tests, code formatting)

Links

  • Jira issue number: (PUT IT HERE)
  • Process.st launch checklist: (PUT IT HERE)

Checklists

Development

  • Prettier was run (if applicable)
  • The behaviour changes in the pull request are covered by specs
  • All tests related to the changed code pass in development

Paperwork

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has a Jira number
  • This pull request has a Process.st launch checklist

Code review

  • Changes have been reviewed by at least one other engineer
  • Security impacts of this change have been considered

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 67b2510

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@raisins/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@00salmon 00salmon requested a review from Locrian24 October 2, 2024 18:09
Locrian24
Locrian24 reviewed Oct 2, 2024
View reviewed changes
packages/react/package.json Outdated Show resolved Hide resolved
packages/react/package.json Outdated Show resolved Hide resolved
Locrian24
Locrian24 previously approved these changes Oct 2, 2024
View reviewed changes
@00salmon 00salmon merged commit 73055b5 into main Oct 2, 2024
1 check passed
@00salmon 00salmon deleted the react-18-bump branch October 2, 2024 21:22
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Locrian24 Locrian24 Locrian24 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@00salmon @Locrian24